rattail/rattail
2
0
Fork 0
Code Issues 7 Pull requests Actions Packages Projects Releases Wiki Activity

Improve 'settings' API functions so they don't require a session.

Browse source 
Seems way handier that way, sometimes.
This commit is contained in:
Lance Edgar 2015-10-20 15:10:31 -05:00
parent e402352dd6
commit 6ffd7235ff
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
rattail/db/api/settings.py
View file

@ -2,7 +2,7 @@
################################################################################ ################################################################################
# #
# Rattail -- Retail Software Framework # Rattail -- Retail Software Framework
# Copyright © 2010-2014 Lance Edgar # Copyright © 2010-2015 Lance Edgar
# #
# This file is part of Rattail. # This file is part of Rattail.
# #
@ -26,27 +26,37 @@ Settings API
from __future__ import unicode_literals from __future__ import unicode_literals
from .. import model from rattail.db import Session, model
__all__ = ['get_setting', 'save_setting']
def get_setting(session, name): def get_setting(session, name):
""" """
Returns a setting value from the database. Returns a setting value from the database.
""" """
local_session = False
if session is None:
session = Session()
local_session = True
setting = session.query(model.Setting).get(name) setting = session.query(model.Setting).get(name)
if setting: value = None if setting is None else setting.value
return setting.value if local_session:
session.close()
return value
def save_setting(session, name, value): def save_setting(session, name, value):
""" """
Saves a setting to the database. Saves a setting to the database.
""" """
local_session = False
if session is None:
session = Session()
local_session = True
setting = session.query(model.Setting).get(name) setting = session.query(model.Setting).get(name)
if not setting: if not setting:
setting = model.Setting(name=name) setting = model.Setting(name=name)
session.add(setting) session.add(setting)
setting.value = value setting.value = value
if local_session:
session.commit()
session.close()