wutta/wuttjamaican
3
0
Fork 0
Code Activity

fix: return empty string instead of None when rendering date/time

Browse source
This commit is contained in:
Lance Edgar 2025-01-15 17:00:02 -06:00
parent e144ca2da8
commit 7608121b37
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/wuttjamaican/app.py
View file

@ -743,9 +743,10 @@ class AppHandler:
:param value: A :class:`python:datetime.date` instance (or :param value: A :class:`python:datetime.date` instance (or
``None``). ``None``).
:returns: Display string, or ``None``. :returns: Display string.
""" """
if value is not None: if value is None:
return ""
return value.strftime(self.display_format_date) return value.strftime(self.display_format_date)
def render_datetime(self, value): def render_datetime(self, value):
@ -757,9 +758,10 @@ class AppHandler:
:param value: A :class:`python:datetime.datetime` instance (or :param value: A :class:`python:datetime.datetime` instance (or
``None``). ``None``).
:returns: Display string, or ``None``. :returns: Display string.
""" """
if value is not None: if value is None:
return ""
return value.strftime(self.display_format_datetime) return value.strftime(self.display_format_datetime)
def render_error(self, error): def render_error(self, error):

4
tests/test_app.py
View file

@ -472,13 +472,13 @@ app_title = WuttaTest
self.assertEqual(self.app.render_currency(value), '($42.42)') self.assertEqual(self.app.render_currency(value), '($42.42)')
def test_render_date(self): def test_render_date(self):
self.assertIsNone(self.app.render_date(None)) self.assertEqual(self.app.render_date(None), '')
dt = datetime.date(2024, 12, 11) dt = datetime.date(2024, 12, 11)
self.assertEqual(self.app.render_date(dt), '2024-12-11') self.assertEqual(self.app.render_date(dt), '2024-12-11')
def test_render_datetime(self): def test_render_datetime(self):
self.assertIsNone(self.app.render_datetime(None)) self.assertEqual(self.app.render_datetime(None), '')
dt = datetime.datetime(2024, 12, 11, 8, 30, tzinfo=datetime.timezone.utc) dt = datetime.datetime(2024, 12, 11, 8, 30, tzinfo=datetime.timezone.utc)
self.assertEqual(self.app.render_datetime(dt), '2024-12-11 08:30+0000') self.assertEqual(self.app.render_datetime(dt), '2024-12-11 08:30+0000')