wutta/wuttaweb
3
0
Fork 0
Code Issues Activity

fix: prefer new setting name for buefy_css liburl

Browse source 
old setting name is still supported for now, with deprecation
warnings.

this change was necessary due to ambiguity of the buefy setting, when
buefy.css setting was set
This commit is contained in:
Lance Edgar 2026-02-07 09:27:50 -06:00
parent 9541bc6a27
commit 5fdba539a0
4 changed files with 129 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

63
tests/test_util.py
View file

@ -95,27 +95,73 @@ class TestGetLibVer(TestCase):
self.assertEqual(version, "0.9.25")
def test_buefy_css_default(self):
version = mod.get_libver(self.request, "buefy_css")
self.assertEqual(version, "0.9.25")
version = mod.get_libver(self.request, "buefy.css")
self.assertEqual(version, "0.9.25")
def test_buefy_css_custom_old(self):
# nb. this uses same setting as buefy (js)
self.config.setdefault("wuttaweb.buefy_version", "0.9.29")
version = mod.get_libver(self.request, "buefy_css")
self.assertEqual(version, "0.9.29")
version = mod.get_libver(self.request, "buefy.css")
self.assertEqual(version, "0.9.29")
def test_buefy_css_custom_new(self):
# nb. this uses same setting as buefy (js)
self.config.setdefault("wuttaweb.libver.buefy", "0.9.29")
version = mod.get_libver(self.request, "buefy_css")
self.assertEqual(version, "0.9.29")
version = mod.get_libver(self.request, "buefy.css")
self.assertEqual(version, "0.9.29")
def test_buefy_css_configured_only(self):
version = mod.get_libver(self.request, "buefy_css", configured_only=True)
self.assertIsNone(version)
version = mod.get_libver(self.request, "buefy.css", configured_only=True)
self.assertIsNone(version)
# legacy prefix + deprecated setting name
self.config.setdefault("tailbone.libver.buefy.css", "0.9.23")
version = mod.get_libver(
self.request, "buefy_css", configured_only=True, prefix="tailbone"
)
self.assertEqual(version, "0.9.23")
version = mod.get_libver(
self.request, "buefy.css", configured_only=True, prefix="tailbone"
)
self.assertEqual(version, "0.9.23")
# legacy prefix + preferred setting name
self.config.setdefault("tailbone.libver.buefy_css", "0.9.22")
version = mod.get_libver(
self.request, "buefy_css", configured_only=True, prefix="tailbone"
)
self.assertEqual(version, "0.9.22")
version = mod.get_libver(
self.request, "buefy.css", configured_only=True, prefix="tailbone"
)
self.assertEqual(version, "0.9.22")
# deprecated setting name
self.config.setdefault("wuttaweb.libver.buefy.css", "0.9.29")
version = mod.get_libver(self.request, "buefy_css", configured_only=True)
self.assertEqual(version, "0.9.29")
version = mod.get_libver(self.request, "buefy.css", configured_only=True)
self.assertEqual(version, "0.9.29")
# preferred setting name
self.config.setdefault("wuttaweb.libver.buefy_css", "0.9.27")
version = mod.get_libver(self.request, "buefy_css", configured_only=True)
self.assertEqual(version, "0.9.27")
version = mod.get_libver(self.request, "buefy.css", configured_only=True)
self.assertEqual(version, "0.9.27")
def test_buefy_css_default_only(self):
self.config.setdefault("wuttaweb.libver.buefy", "0.9.29")
version = mod.get_libver(self.request, "buefy_css", default_only=True)
self.assertEqual(version, "0.9.25")
version = mod.get_libver(self.request, "buefy.css", default_only=True)
self.assertEqual(version, "0.9.25")
@ -291,16 +337,31 @@ class TestGetLibUrl(TestCase):
self.assertEqual(url, "/wutta/fanstatic/buefy.js")
def test_buefy_css_default(self):
url = mod.get_liburl(self.request, "buefy_css")
self.assertEqual(url, "https://unpkg.com/buefy@0.9.25/dist/buefy.min.css")
url = mod.get_liburl(self.request, "buefy.css")
self.assertEqual(url, "https://unpkg.com/buefy@0.9.25/dist/buefy.min.css")
def test_buefy_css_custom(self):
self.config.setdefault("wuttaweb.liburl.buefy.css", "/lib/buefy.css")
# deprecated setting name
self.config.setdefault("wuttaweb.liburl.buefy.css", "/lib/deprecated-buefy.css")
url = mod.get_liburl(self.request, "buefy_css")
self.assertEqual(url, "/lib/deprecated-buefy.css")
url = mod.get_liburl(self.request, "buefy.css")
self.assertEqual(url, "/lib/deprecated-buefy.css")
# preferred setting name
self.config.setdefault("wuttaweb.liburl.buefy_css", "/lib/buefy.css")
url = mod.get_liburl(self.request, "buefy_css")
self.assertEqual(url, "/lib/buefy.css")
url = mod.get_liburl(self.request, "buefy.css")
self.assertEqual(url, "/lib/buefy.css")
def test_buefy_css_fanstatic(self):
self.setup_fanstatic()
url = mod.get_liburl(self.request, "buefy_css")
self.assertEqual(url, "/wutta/fanstatic/buefy.css")
url = mod.get_liburl(self.request, "buefy.css")
self.assertEqual(url, "/wutta/fanstatic/buefy.css")