wutta/wuttasync
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: do not assign simple/supported fields in Importer constructor

Browse source 
subclass may define those and we do not want to overwrite; in some
cases doing so would cause error (if subclass defines a property)
This commit is contained in:
Lance Edgar 2025-06-29 11:19:10 -05:00
parent 4f68a2f360
commit 65bbc95ae2
2 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/wuttasync/importing/base.py
View file

@ -200,8 +200,6 @@ class Importer:
self.__dict__.update(kwargs)
self.simple_fields = self.get_simple_fields()
self.supported_fields = self.get_supported_fields()
self.fields = self.get_fields()
# fields could be comma-delimited string from cli param

2
tests/importing/test_base.py
View file

@ -24,8 +24,6 @@ class TestImporter(DataTestCase):
imp = self.make_importer(model_class=model.Setting)
# fields
self.assertEqual(imp.supported_fields, ['name', 'value'])
self.assertEqual(imp.simple_fields, ['name', 'value'])
self.assertEqual(imp.fields, ['name', 'value'])
# orientation etc.