From 65bbc95ae2df8e6da928d7c82a8129f4fab1ecc5 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Sun, 29 Jun 2025 11:19:10 -0500 Subject: [PATCH] fix: do not assign simple/supported fields in Importer constructor subclass may define those and we do not want to overwrite; in some cases doing so would cause error (if subclass defines a property) --- src/wuttasync/importing/base.py | 2 -- tests/importing/test_base.py | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/wuttasync/importing/base.py b/src/wuttasync/importing/base.py index 59017d7..6e06cfb 100644 --- a/src/wuttasync/importing/base.py +++ b/src/wuttasync/importing/base.py @@ -200,8 +200,6 @@ class Importer: self.__dict__.update(kwargs) - self.simple_fields = self.get_simple_fields() - self.supported_fields = self.get_supported_fields() self.fields = self.get_fields() # fields could be comma-delimited string from cli param diff --git a/tests/importing/test_base.py b/tests/importing/test_base.py index ff2ca6e..feab115 100644 --- a/tests/importing/test_base.py +++ b/tests/importing/test_base.py @@ -24,8 +24,6 @@ class TestImporter(DataTestCase): imp = self.make_importer(model_class=model.Setting) # fields - self.assertEqual(imp.supported_fields, ['name', 'value']) - self.assertEqual(imp.simple_fields, ['name', 'value']) self.assertEqual(imp.fields, ['name', 'value']) # orientation etc.