rattail/tailbone
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Only prevent cache for index pages if so configured

Browse source 
there is a performance hit for this, depending on your perspective, so
let's make it opt-in only for now
This commit is contained in:
Lance Edgar 2022-02-10 20:31:03 -06:00
parent e852613567
commit 9584fb57b0
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tailbone/views/master.py
View file

@ -4490,14 +4490,19 @@ class MasterView(View):
config.add_tailbone_permission(permission_prefix, '{}.list'.format(permission_prefix), config.add_tailbone_permission(permission_prefix, '{}.list'.format(permission_prefix),
"List / search {}".format(model_title_plural)) "List / search {}".format(model_title_plural))
config.add_route(route_prefix, '{}/'.format(url_prefix)) config.add_route(route_prefix, '{}/'.format(url_prefix))
kwargs = {}
if rattail_config.getbool('tailbone',
'prevent_cache_for_index_views',
default=False):
# hopefully, instruct browser to never cache this page.
# on windows/chrome we are seeing some caching when e.g.
# user applies some filters, then views a record, then
# clicks back button, filters no longer are applied
# cf. https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/viewconfig.html#non-predicate-arguments
kwargs['http_cache'] = 0
config.add_view(cls, attr='index', route_name=route_prefix, config.add_view(cls, attr='index', route_name=route_prefix,
permission='{}.list'.format(permission_prefix), permission='{}.list'.format(permission_prefix),
# hopefully, instruct browser to never cache this page. **kwargs)
# on windows/chrome we are seeing some caching when e.g.
# user applies some filters, then views a record, then
# clicks back button, filters no longer are applied
# cf. https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/viewconfig.html#non-predicate-arguments
http_cache=0)
# download results # download results
# this is the "new" more flexible approach, but we only want to # this is the "new" more flexible approach, but we only want to