rattail/tailbone
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Tweak default "numeric" grid filter, to ignore UPC-like values

Browse source 
Those tend to cause SQL errors, so just "fail silently" for now.  This
situation needs to be improved on the front end at some point...
This commit is contained in:
Lance Edgar 2016-12-28 16:42:09 -06:00
parent f67fdb8c5b
commit 8f98d61a38
1 changed files with 42 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tailbone/newgrids/filters.py
View file

@ -366,12 +366,48 @@ class AlchemyNumericFilter(AlchemyGridFilter):
""" """
value_renderer_factory = NumericValueRenderer value_renderer_factory = NumericValueRenderer
def default_verbs(self): # expose greater-than / less-than verbs in addition to core
""" default_verbs = ['equal', 'not_equal', 'greater_than', 'greater_equal',
Expose greater-than / less-than verbs in addition to core. 'less_than', 'less_equal', 'is_null', 'is_not_null']
"""
return ['equal', 'not_equal', 'greater_than', 'greater_equal', # TODO: what follows "works" in that it prevents an error...but from the
'less_than', 'less_equal', 'is_null', 'is_not_null'] # user's perspective it still fails silently...need to improve on front-end
# try to detect (and ignore) common mistake where user enters UPC as search
# term for integer field...
def value_invalid(self, value):
return bool(value and len(value) > 8)
def filter_equal(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_equal(query, value)
def filter_not_equal(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_not_equal(query, value)
def filter_greater_than(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_greater_than(query, value)
def filter_greater_equal(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_greater_equal(query, value)
def filter_less_than(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_less_than(query, value)
def filter_less_equal(self, query, value):
if self.value_invalid(value):
return query
return super(AlchemyNumericFilter, self).filter_less_equal(query, value)
class AlchemyBooleanFilter(AlchemyGridFilter): class AlchemyBooleanFilter(AlchemyGridFilter):