rattail/tailbone
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

Use dict instead of custom object to represent menus

Browse source 
as prep for editing menu config directly in app
This commit is contained in:
Lance Edgar 2022-02-23 00:26:14 -06:00
parent 0c5992ad75
commit 3553f23eab
3 changed files with 63 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

86
tailbone/menus.py
View file

@ -2,7 +2,7 @@
################################################################################
#
# Rattail -- Retail Software Framework
# Copyright © 2010-2021 Lance Edgar
# Copyright © 2010-2022 Lance Edgar
#
# This file is part of Rattail.
#
@ -26,38 +26,11 @@ App Menus
from __future__ import unicode_literals, absolute_import
from rattail.core import Object
import re
from rattail.util import import_module_path
class MenuGroup(Object):
title = None
items = None
is_menu = True
is_link = False
class MenuItem(Object):
title = None
url = None
target = None
is_link = True
is_menu = False
is_sep = False
class MenuItemMenu(Object):
title = None
items = None
is_menu = True
is_sep = False
class MenuSeparator(object):
is_menu = False
is_sep = True
def make_simple_menus(request):
"""
Build the main menu list for the app.
@ -93,30 +66,48 @@ def make_simple_menus(request):
for subitem in item['items']:
if subitem['allowed']:
submenu_items.append(make_menu_entry(subitem))
menu_items.append(MenuItemMenu(
title=item['title'],
items=submenu_items))
menu_items.append({
'type': 'submenu',
'title': item['title'],
'items': submenu_items,
'is_menu': True,
'is_sep': False,
})
elif item.get('type') == 'sep':
# we only want to add a sep, *if* we already have some
# menu items (i.e. there is something to separate)
# *and* the last menu item is not a sep (avoid doubles)
if menu_items and not menu_items[-1].is_sep:
if menu_items and not menu_items[-1]['is_sep']:
menu_items.append(make_menu_entry(item))
else: # standard menu item
menu_items.append(make_menu_entry(item))
# remove final separator if present
if menu_items and menu_items[-1].is_sep:
if menu_items and menu_items[-1]['is_sep']:
menu_items.pop()
# only add if we wound up with something
assert menu_items
if menu_items:
final_menus.append(MenuGroup(
title=topitem['title'],
items=menu_items))
group = {
'type': 'menu',
'key': topitem.get('key'),
'title': topitem['title'],
'items': menu_items,
'is_menu': True,
'is_link': False,
}
# topitem w/ no key likely means it did not come
# from config but rather explicit definition in
# code. so we are free to "invent" a (safe) key
# for it, since that is only for editing config
if not group['key']:
group['key'] = re.sub(r'\W', '', topitem['title'].lower())
final_menus.append(group)
return final_menus
@ -128,13 +119,22 @@ def make_menu_entry(item):
"""
# separator
if item.get('type') == 'sep':
return MenuSeparator()
return {
'type': 'sep',
'is_menu': False,
'is_sep': True,
}
# standard menu item
return MenuItem(
title=item['title'],
url=item['url'],
target=item.get('target'))
return {
'type': 'item',
'title': item['title'],
'url': item['url'],
'target': item.get('target'),
'is_link': True,
'is_menu': False,
'is_sep': False,
}
def is_allowed(request, item):