Accept None
as valid arg for Grid.set_filter()
i.e. to effectively remove the filter
This commit is contained in:
parent
152db68606
commit
2cba0ade84
|
@ -124,7 +124,10 @@ class Grid(object):
|
|||
self.sorters[key] = self.make_sorter(*args, **kwargs)
|
||||
|
||||
def set_filter(self, key, *args, **kwargs):
|
||||
self.filters[key] = self.make_filter(key, *args, **kwargs)
|
||||
if len(args) == 1 and args[0] is None:
|
||||
self.filters.pop(key, None)
|
||||
else:
|
||||
self.filters[key] = self.make_filter(key, *args, **kwargs)
|
||||
|
||||
def set_label(self, key, label):
|
||||
self.labels[key] = label
|
||||
|
|
|
@ -539,12 +539,12 @@ class BatchMasterView(MasterView):
|
|||
self.handler.refresh_batch_status(batch)
|
||||
except Exception as error:
|
||||
session.rollback()
|
||||
log.warning("batch pre-fill failed: {}".format(batch), exc_info=True)
|
||||
log.warning("batch population failed: %s", batch, exc_info=True)
|
||||
session.close()
|
||||
if progress:
|
||||
progress.session.load()
|
||||
progress.session['error'] = True
|
||||
progress.session['error_msg'] = "Batch pre-fill failed: {} {}".format(error.__class__.__name__, error)
|
||||
progress.session['error_msg'] = "Batch population failed: {} - {}".format(error.__class__.__name__, error)
|
||||
progress.session.save()
|
||||
return
|
||||
|
||||
|
|
Loading…
Reference in a new issue