Honor "safe for web app" flags for import/export handlers
This commit is contained in:
		
							parent
							
								
									cc4b2278e7
								
							
						
					
					
						commit
						092f1cda0c
					
				
					 2 changed files with 13 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -44,7 +44,12 @@
 | 
			
		|||
    </once-button>
 | 
			
		||||
    <b-button type="is-primary"
 | 
			
		||||
              @click="submitRun()"
 | 
			
		||||
              % if handler.safe_for_web_app:
 | 
			
		||||
              :disabled="submittingRun"
 | 
			
		||||
              % else:
 | 
			
		||||
              disabled
 | 
			
		||||
              title="Handler is not (yet) safe to run with this tool"
 | 
			
		||||
              % endif
 | 
			
		||||
              icon-pack="fas"
 | 
			
		||||
              icon-left="arrow-circle-right">
 | 
			
		||||
      {{ submittingRun ? "Working, please wait..." : "Run this ${handler.direction.capitalize()}" }}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -129,6 +129,7 @@ class ImportingView(MasterView):
 | 
			
		|||
            'handler_spec': handler.get_spec(),
 | 
			
		||||
            'direction': handler.direction,
 | 
			
		||||
            'direction_display': handler.direction.capitalize(),
 | 
			
		||||
            'safe_for_web_app': handler.safe_for_web_app,
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        if keep_handler:
 | 
			
		||||
| 
						 | 
				
			
			@ -314,7 +315,13 @@ class ImportingView(MasterView):
 | 
			
		|||
 | 
			
		||||
        if self.request.POST.get('runjob') == 'true':
 | 
			
		||||
 | 
			
		||||
            # will invoke handler to run job
 | 
			
		||||
            # will invoke handler to run job..
 | 
			
		||||
 | 
			
		||||
            # ..but only if it is safe to do so
 | 
			
		||||
            if not handler.safe_for_web_app:
 | 
			
		||||
                self.request.session.flash("Handler is not (yet) safe to run "
 | 
			
		||||
                                           "with this tool", 'error')
 | 
			
		||||
                return self.redirect(self.request.current_route_url())
 | 
			
		||||
 | 
			
		||||
            # TODO: this socket progress business was lifted from
 | 
			
		||||
            # tailbone.views.batch.core:BatchMasterView.handler_action
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue