feat: move lookup logic to handler; improve support for external lookup

tests/batch/test_neworder.py

@@ -50,6 +50,34 @@ class TestNewOrderBatchHandler(DataTestCase):
         config.setdefault('sideshow.orders.allow_unknown_products', 'false')
         self.assertFalse(handler.allow_unknown_products())
 
+    def test_autocomplete_customers_external(self):
+        handler = self.make_handler()
+        self.assertRaises(NotImplementedError, handler.autocomplete_customers_external,
+                          self.session, 'jack')
+
+    def test_autocomplete_cutomers_local(self):
+        model = self.app.model
+        handler = self.make_handler()
+
+        # empty results by default
+        self.assertEqual(handler.autocomplete_customers_local(self.session, 'foo'), [])
+
+        # add a customer
+        customer = model.LocalCustomer(full_name="Chuck Norris")
+        self.session.add(customer)
+        self.session.flush()
+
+        # search for chuck finds chuck
+        results = handler.autocomplete_customers_local(self.session, 'chuck')
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0], {
+            'value': customer.uuid.hex,
+            'label': "Chuck Norris",
+        })
+
+        # search for sally finds nothing
+        self.assertEqual(handler.autocomplete_customers_local(self.session, 'sally'), [])
+
     def test_set_customer(self):
         model = self.app.model
         handler = self.make_handler()
@@ -146,6 +174,83 @@ class TestNewOrderBatchHandler(DataTestCase):
         self.assertIsNone(batch.phone_number)
         self.assertIsNone(batch.email_address)
 
+    def test_autocomplete_products_external(self):
+        handler = self.make_handler()
+        self.assertRaises(NotImplementedError, handler.autocomplete_products_external,
+                          self.session, 'cheese')
+
+    def test_autocomplete_products_local(self):
+        model = self.app.model
+        handler = self.make_handler()
+
+        # empty results by default
+        self.assertEqual(handler.autocomplete_products_local(self.session, 'foo'), [])
+
+        # add a product
+        product = model.LocalProduct(brand_name="Bragg's", description="Vinegar")
+        self.session.add(product)
+        self.session.flush()
+
+        # search for vinegar finds product
+        results = handler.autocomplete_products_local(self.session, 'vinegar')
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0], {
+            'value': product.uuid.hex,
+            'label': "Bragg's Vinegar",
+        })
+
+        # search for brag finds product
+        results = handler.autocomplete_products_local(self.session, 'brag')
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0], {
+            'value': product.uuid.hex,
+            'label': "Bragg's Vinegar",
+        })
+
+        # search for juice finds nothing
+        self.assertEqual(handler.autocomplete_products_local(self.session, 'juice'), [])
+
+    def test_get_product_info_external(self):
+        handler = self.make_handler()
+        self.assertRaises(NotImplementedError, handler.get_product_info_external,
+                          self.session, '07430500132')
+
+    def test_get_product_info_local(self):
+        model = self.app.model
+        handler = self.make_handler()
+
+        user = model.User(username='barney')
+        self.session.add(user)
+        local = model.LocalProduct(scancode='07430500132',
+                                   brand_name='Bragg',
+                                   description='Vinegar',
+                                   size='32oz',
+                                   case_size=12,
+                                   unit_price_reg=decimal.Decimal('5.99'))
+        self.session.add(local)
+        self.session.flush()
+
+        batch = handler.make_batch(self.session, created_by=user)
+        self.session.add(batch)
+
+        # typical, for local product
+        info = handler.get_product_info_local(self.session, local.uuid.hex)
+        self.assertEqual(info['product_id'], local.uuid.hex)
+        self.assertEqual(info['scancode'], '07430500132')
+        self.assertEqual(info['brand_name'], 'Bragg')
+        self.assertEqual(info['description'], 'Vinegar')
+        self.assertEqual(info['size'], '32oz')
+        self.assertEqual(info['full_description'], 'Bragg Vinegar 32oz')
+        self.assertEqual(info['case_size'], 12)
+        self.assertEqual(info['unit_price_reg'], decimal.Decimal('5.99'))
+
+        # error if no product_id
+        self.assertRaises(ValueError, handler.get_product_info_local, self.session, None)
+
+        # error if product not found
+        mock_uuid = self.app.make_true_uuid()
+        self.assertRaises(ValueError, handler.get_product_info_local, self.session, mock_uuid.hex)
+
     def test_add_item(self):
         model = self.app.model
         enum = self.app.enum
@@ -719,10 +824,8 @@ class TestNewOrderBatchHandler(DataTestCase):
         self.session.add(row)
         self.session.flush()
         # STATUS_OK
-        row = handler.make_row(product_id=42, order_qty=1, order_uom=enum.ORDER_UOM_UNIT)
-        handler.add_row(batch, row)
-        self.session.add(row)
-        self.session.commit()
+        row = handler.add_item(batch, {'scancode': '07430500132'}, 1, enum.ORDER_UOM_UNIT)
+        self.session.flush()
 
         # only 1 effective row
         rows = handler.get_effective_rows(batch)