From 35af58bfb132cc736f8a09e44544df8db604a11b Mon Sep 17 00:00:00 2001
From: Lance Edgar <lance@wuttaproject.org>
Date: Tue, 23 Dec 2025 17:29:56 -0600
Subject: [PATCH] fix: show deprecation warnings by default for 'wutt*'
 packages

---
 src/wuttjamaican/conf.py | 76 ++++++++++++++++++++++++----------------
 1 file changed, 45 insertions(+), 31 deletions(-)

diff --git a/src/wuttjamaican/conf.py b/src/wuttjamaican/conf.py
index c799da6..9a723d9 100644
--- a/src/wuttjamaican/conf.py
+++ b/src/wuttjamaican/conf.py
@@ -31,6 +31,7 @@ import logging.config
 import os
 import sys
 import tempfile
+import warnings
 
 import config as configuration
 
@@ -1020,41 +1021,54 @@ def make_config(  # pylint: disable=too-many-arguments,too-many-positional-argum
 
     :returns: The new config object.
     """
-    # collect file paths
-    files = get_config_paths(
-        files=files,
-        plus_files=plus_files,
-        appname=appname,
-        env_files_name=env_files_name,
-        env_plus_files_name=env_plus_files_name,
-        env=env,
-        default_files=default_files,
-        winsvc=winsvc,
-    )
 
-    # make config object
-    if not factory:
-        factory = WuttaConfig
-    config = factory(files, appname=appname, usedb=usedb, preferdb=preferdb, **kwargs)
+    # nb. always show deprecation warnings when making config
+    with warnings.catch_warnings():
+        warnings.filterwarnings("default", category=DeprecationWarning, module=r"^wutt")
 
-    # maybe extend config object
-    if extend:
-        if not extension_entry_points:
-            # nb. must not use appname here, entry points must be
-            # consistent regardless of appname
-            extension_entry_points = "wutta.config.extensions"
+        # collect file paths
+        files = get_config_paths(
+            files=files,
+            plus_files=plus_files,
+            appname=appname,
+            env_files_name=env_files_name,
+            env_plus_files_name=env_plus_files_name,
+            env=env,
+            default_files=default_files,
+            winsvc=winsvc,
+        )
 
-        # apply all registered extensions
-        # TODO: maybe let config disable some extensions?
-        extensions = load_entry_points(extension_entry_points)
-        extensions = [ext() for ext in extensions.values()]
-        for extension in extensions:
-            log.debug("applying config extension: %s", extension.key)
-            extension.configure(config)
+        # make config object
+        if not factory:
+            factory = WuttaConfig
+        config = factory(
+            files, appname=appname, usedb=usedb, preferdb=preferdb, **kwargs
+        )
 
-        # let extensions run startup hooks if needed
-        for extension in extensions:
-            extension.startup(config)
+        # maybe extend config object
+        if extend:
+            if not extension_entry_points:
+                # nb. must not use appname here, entry points must be
+                # consistent regardless of appname
+                extension_entry_points = "wutta.config.extensions"
+
+            # apply all registered extensions
+            # TODO: maybe let config disable some extensions?
+            extensions = load_entry_points(extension_entry_points)
+            extensions = [ext() for ext in extensions.values()]
+            for extension in extensions:
+                log.debug("applying config extension: %s", extension.key)
+                extension.configure(config)
+
+            # let extensions run startup hooks if needed
+            for extension in extensions:
+                extension.startup(config)
+
+    # maybe show deprecation warnings from now on
+    if config.get_bool(
+        f"{config.appname}.show_deprecation_warnings", usedb=False, default=True
+    ):
+        warnings.filterwarnings("default", category=DeprecationWarning, module=r"^wutt")
 
     return config