From e123b12cd9a46d2970f58a0277034916ae01752c Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Mon, 1 Sep 2025 11:06:47 -0500 Subject: [PATCH] fix: fix 'keyword-arg-before-vararg' for pylint --- .pylintrc | 1 - src/wuttaweb/forms/schema.py | 9 ++------- src/wuttaweb/forms/widgets.py | 3 ++- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.pylintrc b/.pylintrc index e0e154b..7af1cf2 100644 --- a/.pylintrc +++ b/.pylintrc @@ -6,5 +6,4 @@ disable=fixme, arguments-renamed, attribute-defined-outside-init, duplicate-code, - keyword-arg-before-vararg, no-member, diff --git a/src/wuttaweb/forms/schema.py b/src/wuttaweb/forms/schema.py index 271bdd9..f790f3a 100644 --- a/src/wuttaweb/forms/schema.py +++ b/src/wuttaweb/forms/schema.py @@ -288,13 +288,8 @@ class ObjectRef(colander.SchemaType): default_empty_option = ("", "(none)") - def __init__( - self, - request, - empty_option=None, - *args, - **kwargs, - ): + def __init__(self, request, *args, **kwargs): + empty_option = kwargs.pop("empty_option", None) # nb. allow session injection for tests self.session = kwargs.pop("session", Session()) super().__init__(*args, **kwargs) diff --git a/src/wuttaweb/forms/widgets.py b/src/wuttaweb/forms/widgets.py index f33f0fd..ae233bb 100644 --- a/src/wuttaweb/forms/widgets.py +++ b/src/wuttaweb/forms/widgets.py @@ -103,7 +103,8 @@ class ObjectRefWidget(SelectWidget): readonly_template = "readonly/objectref" - def __init__(self, request, url=None, *args, **kwargs): + def __init__(self, request, *args, **kwargs): + url = kwargs.pop("url", None) super().__init__(*args, **kwargs) self.request = request self.url = url