diff --git a/.pylintrc b/.pylintrc index fc8037d..4431a80 100644 --- a/.pylintrc +++ b/.pylintrc @@ -5,7 +5,6 @@ disable=fixme, arguments-differ, arguments-renamed, attribute-defined-outside-init, - consider-using-dict-comprehension, consider-using-dict-items, consider-using-generator, consider-using-get, diff --git a/src/wuttaweb/grids/filters.py b/src/wuttaweb/grids/filters.py index f939836..c22b75c 100644 --- a/src/wuttaweb/grids/filters.py +++ b/src/wuttaweb/grids/filters.py @@ -248,7 +248,7 @@ class GridFilter: # pylint: disable=too-many-instance-attributes Returns a dict of all defined verb labels. """ # TODO: should traverse hierarchy - labels = dict([(verb, verb) for verb in self.get_verbs()]) + labels = {verb: verb for verb in self.get_verbs()} labels.update(self.default_verb_labels) return labels diff --git a/src/wuttaweb/views/batch.py b/src/wuttaweb/views/batch.py index 3690a20..036bf88 100644 --- a/src/wuttaweb/views/batch.py +++ b/src/wuttaweb/views/batch.py @@ -235,13 +235,11 @@ class BatchMasterView(MasterView): batch = schema.objectify(form.validated, context=form.model_instance) # then we collect attributes from the new batch - kw = dict( - [ - (key, getattr(batch, key)) - for key in form.validated - if hasattr(batch, key) - ] - ) + kw = { + key: getattr(batch, key) + for key in form.validated + if hasattr(batch, key) + } # and set attribute for user creating the batch kw["created_by"] = self.request.user diff --git a/src/wuttaweb/views/master.py b/src/wuttaweb/views/master.py index be7d7f2..509ba26 100644 --- a/src/wuttaweb/views/master.py +++ b/src/wuttaweb/views/master.py @@ -2248,9 +2248,9 @@ class MasterView(View): # pylint: disable=too-many-public-methods :returns: The dict of route kwargs for the object. """ try: - return dict([(key, obj[key]) for key in self.get_model_key()]) + return {key: obj[key] for key in self.get_model_key()} except TypeError: - return dict([(key, getattr(obj, key)) for key in self.get_model_key()]) + return {key: getattr(obj, key) for key in self.get_model_key()} def get_action_url(self, action, obj, **kwargs): """