From 7b7fb6d7b86d1b57a91bad622cb00be45f3a7223 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Mon, 1 Sep 2025 19:38:57 -0500 Subject: [PATCH] fix: explicitly disable 'duplicate-code' false alarm so we can keep default config for that checker --- .pylintrc | 6 +----- src/wuttaweb/forms/schema.py | 3 +++ src/wuttaweb/forms/widgets.py | 3 +++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.pylintrc b/.pylintrc index 5a30127..7eb5e2c 100644 --- a/.pylintrc +++ b/.pylintrc @@ -1,8 +1,4 @@ # -*- mode: conf; -*- [MESSAGES CONTROL] -disable=fixme, - -[SIMILARITIES] -# nb. cuts out some noise for duplicate-code -min-similarity-lines=5 +disable=fixme diff --git a/src/wuttaweb/forms/schema.py b/src/wuttaweb/forms/schema.py index e42ac33..f19e8c3 100644 --- a/src/wuttaweb/forms/schema.py +++ b/src/wuttaweb/forms/schema.py @@ -634,6 +634,7 @@ class FileDownload(colander.String): name/size is shown with no hyperlink. """ + # pylint: disable=duplicate-code def __init__(self, request, *args, **kwargs): self.url = kwargs.pop("url", None) super().__init__(*args, **kwargs) @@ -641,6 +642,8 @@ class FileDownload(colander.String): self.config = self.request.wutta_config self.app = self.config.get_app() + # pylint: enable=duplicate-code + def widget_maker(self, **kwargs): # pylint: disable=empty-docstring """ """ kwargs.setdefault("url", self.url) diff --git a/src/wuttaweb/forms/widgets.py b/src/wuttaweb/forms/widgets.py index 55eea47..8dc6241 100644 --- a/src/wuttaweb/forms/widgets.py +++ b/src/wuttaweb/forms/widgets.py @@ -321,6 +321,7 @@ class FileDownloadWidget(Widget): # pylint: disable=abstract-method readonly_template = "readonly/filedownload" + # pylint: disable=duplicate-code def __init__(self, request, *args, **kwargs): self.url = kwargs.pop("url", None) super().__init__(*args, **kwargs) @@ -328,6 +329,8 @@ class FileDownloadWidget(Widget): # pylint: disable=abstract-method self.config = self.request.wutta_config self.app = self.config.get_app() + # pylint: enable=duplicate-code + def serialize(self, field, cstruct, **kw): # pylint: disable=empty-docstring """ """ # nb. readonly is the only way this rolls