From 71362408415e04497364add4f93db93fe6df837e Mon Sep 17 00:00:00 2001
From: Lance Edgar <lance@wuttaproject.org>
Date: Sun, 31 Aug 2025 22:51:28 -0500
Subject: [PATCH] fix: fix 'unused-argument' for pylint

---
 .pylintrc                      |  1 -
 src/wuttaweb/app.py            |  4 ++--
 src/wuttaweb/auth.py           |  2 +-
 src/wuttaweb/cli/webapp.py     |  2 +-
 src/wuttaweb/forms/base.py     |  2 +-
 src/wuttaweb/forms/schema.py   |  4 +++-
 src/wuttaweb/grids/base.py     | 18 +++++++++++-------
 src/wuttaweb/grids/filters.py  | 12 ++++++------
 src/wuttaweb/handler.py        |  2 +-
 src/wuttaweb/menus.py          |  6 +++---
 src/wuttaweb/testing.py        |  2 +-
 src/wuttaweb/views/base.py     |  2 +-
 src/wuttaweb/views/batch.py    |  8 ++++++--
 src/wuttaweb/views/email.py    |  4 +++-
 src/wuttaweb/views/master.py   | 26 +++++++++++++++-----------
 src/wuttaweb/views/upgrades.py |  4 +++-
 src/wuttaweb/views/users.py    |  4 +++-
 17 files changed, 61 insertions(+), 42 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index 1a4690b..3101825 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -39,4 +39,3 @@ disable=fixme,
         unnecessary-lambda,
         unnecessary-lambda-assignment,
         unspecified-encoding,
-        unused-argument,
diff --git a/src/wuttaweb/app.py b/src/wuttaweb/app.py
index f7f768e..1593095 100644
--- a/src/wuttaweb/app.py
+++ b/src/wuttaweb/app.py
@@ -52,7 +52,7 @@ class WebAppProvider(AppProvider):
     email_modules = ["wuttaweb.emails"]
     email_templates = ["wuttaweb:email-templates"]
 
-    def get_web_handler(self, **kwargs):
+    def get_web_handler(self):
         """
         Get the configured "web" handler for the app.
 
@@ -167,7 +167,7 @@ def make_pyramid_config(settings):
     return pyramid_config
 
 
-def main(global_config, **settings):
+def main(global_config, **settings):  # pylint: disable=unused-argument
     """
     Make and return the WSGI application, per given settings.
 
diff --git a/src/wuttaweb/auth.py b/src/wuttaweb/auth.py
index e18cb78..e6222c0 100644
--- a/src/wuttaweb/auth.py
+++ b/src/wuttaweb/auth.py
@@ -137,7 +137,7 @@ class WuttaSecurityPolicy:
     def forget(self, request, **kw):
         return self.session_helper.forget(request, **kw)
 
-    def permits(self, request, context, permission):
+    def permits(self, request, context, permission):  # pylint: disable=unused-argument
 
         # nb. root user can do anything
         if getattr(request, "is_root", False):
diff --git a/src/wuttaweb/cli/webapp.py b/src/wuttaweb/cli/webapp.py
index 24695a4..b7fa076 100644
--- a/src/wuttaweb/cli/webapp.py
+++ b/src/wuttaweb/cli/webapp.py
@@ -35,7 +35,7 @@ from wuttjamaican.cli import wutta_typer
 
 
 @wutta_typer.command()
-def webapp(
+def webapp(  # pylint: disable=unused-argument
     ctx: typer.Context,
     auto_reload: Annotated[
         bool,
diff --git a/src/wuttaweb/forms/base.py b/src/wuttaweb/forms/base.py
index 8eeed6f..a4a469a 100644
--- a/src/wuttaweb/forms/base.py
+++ b/src/wuttaweb/forms/base.py
@@ -982,7 +982,7 @@ class Form:  # pylint: disable=too-many-instance-attributes
         output = render(template, context)
         return HTML.literal(output)
 
-    def render_vue_field(
+    def render_vue_field(  # pylint: disable=unused-argument
         self,
         fieldname,
         readonly=None,
diff --git a/src/wuttaweb/forms/schema.py b/src/wuttaweb/forms/schema.py
index f3384b1..dc839fb 100644
--- a/src/wuttaweb/forms/schema.py
+++ b/src/wuttaweb/forms/schema.py
@@ -352,7 +352,9 @@ class ObjectRef(colander.SchemaType):
         """
         return obj.uuid.hex
 
-    def deserialize(self, node, cstruct):  # pylint: disable=empty-docstring
+    def deserialize(  # pylint: disable=empty-docstring,unused-argument
+        self, node, cstruct
+    ):
         """ """
         if not cstruct:
             return colander.null
diff --git a/src/wuttaweb/grids/base.py b/src/wuttaweb/grids/base.py
index ed626fe..be97756 100644
--- a/src/wuttaweb/grids/base.py
+++ b/src/wuttaweb/grids/base.py
@@ -1932,7 +1932,7 @@ class Grid:  # pylint: disable=too-many-instance-attributes
     # rendering methods
     ##############################
 
-    def render_batch_id(self, obj, key, value):
+    def render_batch_id(self, obj, key, value):  # pylint: disable=unused-argument
         """
         Column renderer for batch ID values.
 
@@ -1946,7 +1946,7 @@ class Grid:  # pylint: disable=too-many-instance-attributes
         batch_id = int(value)
         return f"{batch_id:08d}"
 
-    def render_boolean(self, obj, key, value):
+    def render_boolean(self, obj, key, value):  # pylint: disable=unused-argument
         """
         Column renderer for boolean values.
 
@@ -1961,7 +1961,9 @@ class Grid:  # pylint: disable=too-many-instance-attributes
         """
         return self.app.render_boolean(value)
 
-    def render_currency(self, obj, key, value, **kwargs):
+    def render_currency(  # pylint: disable=unused-argument
+        self, obj, key, value, **kwargs
+    ):
         """
         Column renderer for currency values.
 
@@ -1976,7 +1978,7 @@ class Grid:  # pylint: disable=too-many-instance-attributes
         """
         return self.app.render_currency(value, **kwargs)
 
-    def render_date(self, obj, key, value):
+    def render_date(self, obj, key, value):  # pylint: disable=unused-argument
         """
         Column renderer for :class:`python:datetime.date` values.
 
@@ -1992,7 +1994,7 @@ class Grid:  # pylint: disable=too-many-instance-attributes
         dt = getattr(obj, key)
         return self.app.render_date(dt)
 
-    def render_datetime(self, obj, key, value):
+    def render_datetime(self, obj, key, value):  # pylint: disable=unused-argument
         """
         Column renderer for :class:`python:datetime.datetime` values.
 
@@ -2035,7 +2037,9 @@ class Grid:  # pylint: disable=too-many-instance-attributes
 
         return value
 
-    def render_percent(self, obj, key, value, **kwargs):
+    def render_percent(  # pylint: disable=unused-argument
+        self, obj, key, value, **kwargs
+    ):
         """
         Column renderer for percentage values.
 
@@ -2049,7 +2053,7 @@ class Grid:  # pylint: disable=too-many-instance-attributes
         """
         return self.app.render_percent(value, **kwargs)
 
-    def render_quantity(self, obj, key, value):
+    def render_quantity(self, obj, key, value):  # pylint: disable=unused-argument
         """
         Column renderer for quantity values.
 
diff --git a/src/wuttaweb/grids/filters.py b/src/wuttaweb/grids/filters.py
index 9bf2b9f..331aebc 100644
--- a/src/wuttaweb/grids/filters.py
+++ b/src/wuttaweb/grids/filters.py
@@ -380,7 +380,7 @@ class GridFilter:  # pylint: disable=too-many-instance-attributes
         # invoke filter method
         return func(data, value)
 
-    def filter_is_any(self, data, value):
+    def filter_is_any(self, data, value):  # pylint: disable=unused-argument
         """
         This is a no-op which always ignores the value and returns the
         data as-is.
@@ -487,13 +487,13 @@ class AlchemyFilter(GridFilter):
             return query
         return query.filter(self.model_property <= value)
 
-    def filter_is_null(self, query, value):
+    def filter_is_null(self, query, value):  # pylint: disable=unused-argument
         """
         Filter data with an ``IS NULL`` query.  The value is ignored.
         """
         return query.filter(self.model_property == None)
 
-    def filter_is_not_null(self, query, value):
+    def filter_is_not_null(self, query, value):  # pylint: disable=unused-argument
         """
         Filter data with an ``IS NOT NULL`` query.  The value is
         ignored.
@@ -623,21 +623,21 @@ class BooleanAlchemyFilter(AlchemyFilter):
             return bool(value)
         return None
 
-    def filter_is_true(self, query, value):
+    def filter_is_true(self, query, value):  # pylint: disable=unused-argument
         """
         Filter data with an "is true" condition.  The value is
         ignored.
         """
         return query.filter(self.model_property == True)
 
-    def filter_is_false(self, query, value):
+    def filter_is_false(self, query, value):  # pylint: disable=unused-argument
         """
         Filter data with an "is false" condition.  The value is
         ignored.
         """
         return query.filter(self.model_property == False)
 
-    def filter_is_false_null(self, query, value):
+    def filter_is_false_null(self, query, value):  # pylint: disable=unused-argument
         """
         Filter data with "is false or null" condition.  The value is
         ignored.
diff --git a/src/wuttaweb/handler.py b/src/wuttaweb/handler.py
index e3520b5..3b63022 100644
--- a/src/wuttaweb/handler.py
+++ b/src/wuttaweb/handler.py
@@ -107,7 +107,7 @@ class WebHandler(GenericHandler):
             return url
         return self.get_fanstatic_url(request, static.logo)
 
-    def get_menu_handler(self, **kwargs):
+    def get_menu_handler(self):
         """
         Get the configured :term:`menu handler` for the web app.
 
diff --git a/src/wuttaweb/menus.py b/src/wuttaweb/menus.py
index f8c44c1..10e9a97 100644
--- a/src/wuttaweb/menus.py
+++ b/src/wuttaweb/menus.py
@@ -89,7 +89,7 @@ class MenuHandler(GenericHandler):
     # default menu definitions
     ##############################
 
-    def make_menus(self, request, **kwargs):
+    def make_menus(self, request):
         """
         Generate the full set of menus for the app.
 
@@ -109,7 +109,7 @@ class MenuHandler(GenericHandler):
             self.make_admin_menu(request),
         ]
 
-    def make_people_menu(self, request, **kwargs):
+    def make_people_menu(self, request):  # pylint: disable=unused-argument
         """
         Generate a typical People menu.
 
@@ -132,7 +132,7 @@ class MenuHandler(GenericHandler):
             ],
         }
 
-    def make_admin_menu(self, request, **kwargs):
+    def make_admin_menu(self, request, **kwargs):  # pylint: disable=unused-argument
         """
         Generate a typical Admin menu.
 
diff --git a/src/wuttaweb/testing.py b/src/wuttaweb/testing.py
index cced4ef..d6f6767 100644
--- a/src/wuttaweb/testing.py
+++ b/src/wuttaweb/testing.py
@@ -76,7 +76,7 @@ class WebTestCase(DataTestCase):
         event = MagicMock(request=self.request)
         subscribers.new_request(event)
 
-        def user_getter(request, **kwargs):
+        def user_getter(request, **kwargs):  # pylint: disable=unused-argument
             pass
 
         subscribers.new_request_set_user(
diff --git a/src/wuttaweb/views/base.py b/src/wuttaweb/views/base.py
index dd00877..04ce768 100644
--- a/src/wuttaweb/views/base.py
+++ b/src/wuttaweb/views/base.py
@@ -54,7 +54,7 @@ class View:
        Reference to the app :term:`config object`.
     """
 
-    def __init__(self, request, context=None):
+    def __init__(self, request, context=None):  # pylint: disable=unused-argument
         self.request = request
         self.config = self.request.wutta_config
         self.app = self.config.get_app()
diff --git a/src/wuttaweb/views/batch.py b/src/wuttaweb/views/batch.py
index 23441ab..3690a20 100644
--- a/src/wuttaweb/views/batch.py
+++ b/src/wuttaweb/views/batch.py
@@ -144,7 +144,9 @@ class BatchMasterView(MasterView):
         # description
         g.set_link("description")
 
-    def render_batch_id(self, batch, key, value):  # pylint: disable=empty-docstring
+    def render_batch_id(  # pylint: disable=empty-docstring,unused-argument
+        self, batch, key, value
+    ):
         """ """
         if value:
             batch_id = int(value)
@@ -406,7 +408,9 @@ class BatchMasterView(MasterView):
 
         g.set_renderer("status_code", self.render_row_status)
 
-    def render_row_status(self, row, key, value):  # pylint: disable=empty-docstring
+    def render_row_status(  # pylint: disable=empty-docstring,unused-argument
+        self, row, key, value
+    ):
         """ """
         return row.STATUS.get(value, value)
 
diff --git a/src/wuttaweb/views/email.py b/src/wuttaweb/views/email.py
index 34e6a29..a50977f 100644
--- a/src/wuttaweb/views/email.py
+++ b/src/wuttaweb/views/email.py
@@ -122,7 +122,9 @@ class EmailSettingView(MasterView):
         # to
         g.set_renderer("to", self.render_to_short)
 
-    def render_to_short(self, setting, field, value):  # pylint: disable=empty-docstring
+    def render_to_short(  # pylint: disable=empty-docstring,unused-argument
+        self, setting, field, value
+    ):
         """ """
         recips = value
         if not recips:
diff --git a/src/wuttaweb/views/master.py b/src/wuttaweb/views/master.py
index b4a5591..a356534 100644
--- a/src/wuttaweb/views/master.py
+++ b/src/wuttaweb/views/master.py
@@ -814,7 +814,7 @@ class MasterView(View):
         return self.render_progress(progress)
 
     def delete_bulk_thread(  # pylint: disable=empty-docstring
-        self, query, success_url=None, progress=None
+        self, query, progress=None
     ):
         """ """
         model_title_plural = self.get_model_title_plural()
@@ -859,7 +859,7 @@ class MasterView(View):
         """
         model_title_plural = self.get_model_title_plural()
 
-        def delete(obj, i):
+        def delete(obj, i):  # pylint: disable=unused-argument
             if self.is_deletable(obj):
                 self.delete_instance(obj)
 
@@ -1440,7 +1440,7 @@ class MasterView(View):
     # grid rendering methods
     ##############################
 
-    def grid_render_bool(self, record, key, value):
+    def grid_render_bool(self, record, key, value):  # pylint: disable=unused-argument
         """
         Custom grid value renderer for "boolean" fields.
 
@@ -1537,7 +1537,9 @@ class MasterView(View):
 
         return value
 
-    def grid_render_notes(self, record, key, value, maxlen=100):
+    def grid_render_notes(  # pylint: disable=unused-argument
+        self, record, key, value, maxlen=100
+    ):
         """
         Custom grid value renderer for "notes" fields.
 
@@ -1694,7 +1696,7 @@ class MasterView(View):
 
         return button
 
-    def get_xref_buttons(self, obj):
+    def get_xref_buttons(self, obj):  # pylint: disable=unused-argument
         """
         Should return a list of "cross-reference" buttons to be shown
         when viewing the given object.
@@ -2078,7 +2080,9 @@ class MasterView(View):
             return self.grid_columns
         return None
 
-    def get_grid_data(self, columns=None, session=None):
+    def get_grid_data(  # pylint: disable=unused-argument
+        self, columns=None, session=None
+    ):
         """
         Returns the grid data for the :meth:`index()` view.
 
@@ -2268,7 +2272,7 @@ class MasterView(View):
         route_prefix = self.get_route_prefix()
         return self.request.route_url(f"{route_prefix}.{action}", **kw)
 
-    def get_action_url_view(self, obj, i):
+    def get_action_url_view(self, obj, i):  # pylint: disable=unused-argument
         """
         Returns the "view" grid action URL for the given object.
 
@@ -2279,7 +2283,7 @@ class MasterView(View):
         """
         return self.get_action_url("view", obj)
 
-    def get_action_url_edit(self, obj, i):
+    def get_action_url_edit(self, obj, i):  # pylint: disable=unused-argument
         """
         Returns the "edit" grid action URL for the given object, if
         applicable.
@@ -2296,7 +2300,7 @@ class MasterView(View):
             return self.get_action_url("edit", obj)
         return None
 
-    def get_action_url_delete(self, obj, i):
+    def get_action_url_delete(self, obj, i):  # pylint: disable=unused-argument
         """
         Returns the "delete" grid action URL for the given object, if
         applicable.
@@ -2313,7 +2317,7 @@ class MasterView(View):
             return self.get_action_url("delete", obj)
         return None
 
-    def is_editable(self, obj):
+    def is_editable(self, obj):  # pylint: disable=unused-argument
         """
         Returns a boolean indicating whether "edit" should be allowed
         for the given model instance (and for current user).
@@ -2326,7 +2330,7 @@ class MasterView(View):
         """
         return True
 
-    def is_deletable(self, obj):
+    def is_deletable(self, obj):  # pylint: disable=unused-argument
         """
         Returns a boolean indicating whether "delete" should be
         allowed for the given model instance (and for current user).
diff --git a/src/wuttaweb/views/upgrades.py b/src/wuttaweb/views/upgrades.py
index a3bc205..03c23ae 100644
--- a/src/wuttaweb/views/upgrades.py
+++ b/src/wuttaweb/views/upgrades.py
@@ -110,7 +110,9 @@ class UpgradeView(MasterView):
         )
         g.set_filter("executed_by", Executor.username, label="Executed By Username")
 
-    def grid_row_class(self, upgrade, data, i):  # pylint: disable=empty-docstring
+    def grid_row_class(  # pylint: disable=empty-docstring,unused-argument
+        self, upgrade, data, i
+    ):
         """ """
         enum = self.app.enum
         if upgrade.status == enum.UpgradeStatus.EXECUTING:
diff --git a/src/wuttaweb/views/users.py b/src/wuttaweb/views/users.py
index cd09c66..eefc4af 100644
--- a/src/wuttaweb/views/users.py
+++ b/src/wuttaweb/views/users.py
@@ -98,7 +98,9 @@ class UserView(MasterView):
         g.set_sorter("person", model.Person.full_name)
         g.set_filter("person", model.Person.full_name, label="Person Full Name")
 
-    def grid_row_class(self, user, data, i):  # pylint: disable=empty-docstring
+    def grid_row_class(  # pylint: disable=empty-docstring,unused-argument
+        self, user, data, i
+    ):
         """ """
         if not user.active:
             return "has-background-warning"