From 6424432f1bc6902b598c621ef8d5f4df984711e9 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Sun, 31 Aug 2025 20:16:23 -0500 Subject: [PATCH] fix: fix 'too-many-branches' for pylint probably should actually refactor some of this? but ignore for now --- .pylintrc | 1 + src/wuttaweb/forms/base.py | 2 +- src/wuttaweb/grids/base.py | 2 +- src/wuttaweb/menus.py | 4 ++-- src/wuttaweb/util.py | 4 ++-- src/wuttaweb/views/batch.py | 2 +- src/wuttaweb/views/email.py | 2 +- 7 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.pylintrc b/.pylintrc index 0a6b1d4..e9784ac 100644 --- a/.pylintrc +++ b/.pylintrc @@ -4,5 +4,6 @@ disable=all enable= inconsistent-return-statements, + too-many-branches, too-many-instance-attributes, too-many-return-statements, diff --git a/src/wuttaweb/forms/base.py b/src/wuttaweb/forms/base.py index 84ab97c..bc738f0 100644 --- a/src/wuttaweb/forms/base.py +++ b/src/wuttaweb/forms/base.py @@ -777,7 +777,7 @@ class Form: # pylint: disable=too-many-instance-attributes self.config, model_class=model_class or self.model_class ) - def get_schema(self): + def get_schema(self): # pylint: disable=too-many-branches """ Return the :class:`colander:colander.Schema` object for the form, generating it automatically if necessary. diff --git a/src/wuttaweb/grids/base.py b/src/wuttaweb/grids/base.py index ffd6891..a2f7971 100644 --- a/src/wuttaweb/grids/base.py +++ b/src/wuttaweb/grids/base.py @@ -1462,7 +1462,7 @@ class Grid: # pylint: disable=too-many-instance-attributes # configuration methods ############################## - def load_settings(self, persist=True): + def load_settings(self, persist=True): # pylint: disable=too-many-branches """ Load all effective settings for the grid. diff --git a/src/wuttaweb/menus.py b/src/wuttaweb/menus.py index 507e6a7..f8c44c1 100644 --- a/src/wuttaweb/menus.py +++ b/src/wuttaweb/menus.py @@ -2,7 +2,7 @@ ################################################################################ # # wuttaweb -- Web App for Wutta Framework -# Copyright © 2024 Lance Edgar +# Copyright © 2024-2025 Lance Edgar # # This file is part of Wutta Framework. # @@ -213,7 +213,7 @@ class MenuHandler(GenericHandler): # default internal logic ############################## - def do_make_menus(self, request, **kwargs): + def do_make_menus(self, request, **kwargs): # pylint: disable=too-many-branches """ This method is responsible for constructing the final menu set. It first calls :meth:`make_menus()` to get the basic diff --git a/src/wuttaweb/util.py b/src/wuttaweb/util.py index 9b5a0c9..2928dde 100644 --- a/src/wuttaweb/util.py +++ b/src/wuttaweb/util.py @@ -141,7 +141,7 @@ def get_form_data(request): return request.POST -def get_libver( # pylint: disable=too-many-return-statements +def get_libver( # pylint: disable=too-many-return-statements,too-many-branches request, key, configured_only=False, @@ -281,7 +281,7 @@ def get_libver( # pylint: disable=too-many-return-statements return None -def get_liburl( # pylint: disable=too-many-return-statements +def get_liburl( # pylint: disable=too-many-return-statements,too-many-branches request, key, configured_only=False, diff --git a/src/wuttaweb/views/batch.py b/src/wuttaweb/views/batch.py index 94ede6d..f138fde 100644 --- a/src/wuttaweb/views/batch.py +++ b/src/wuttaweb/views/batch.py @@ -157,7 +157,7 @@ class BatchMasterView(MasterView): return f"{batch.id_str} {batch.description}" return batch.id_str - def configure_form(self, f): + def configure_form(self, f): # pylint: disable=too-many-branches """ """ super().configure_form(f) batch = f.model_instance diff --git a/src/wuttaweb/views/email.py b/src/wuttaweb/views/email.py index f9847ad..1e136a2 100644 --- a/src/wuttaweb/views/email.py +++ b/src/wuttaweb/views/email.py @@ -173,7 +173,7 @@ class EmailSettingView(MasterView): # enabled f.set_node("enabled", colander.Boolean()) - def persist(self, setting): + def persist(self, setting): # pylint: disable=too-many-branches """ """ session = self.Session() key = self.request.matchdict["key"]