From c3e262804c6e46eead63a67d42c11575bf077b9a Mon Sep 17 00:00:00 2001
From: Lance Edgar <lance@wuttaproject.org>
Date: Mon, 1 Sep 2025 15:13:59 -0500
Subject: [PATCH] fix: fix 'consider-using-dict-comprehension' for pylint

---
 .pylintrc                        |  1 -
 src/sideshow/batch/neworder.py   |  4 ++--
 src/sideshow/web/views/orders.py | 10 ++++------
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index 9d51cdd..0fb067a 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -8,4 +8,3 @@ disable=fixme,
         arguments-renamed,
         attribute-defined-outside-init,
         broad-exception-caught,
-        consider-using-dict-comprehension,
diff --git a/src/sideshow/batch/neworder.py b/src/sideshow/batch/neworder.py
index 09c07cf..9f78da7 100644
--- a/src/sideshow/batch/neworder.py
+++ b/src/sideshow/batch/neworder.py
@@ -1255,7 +1255,7 @@ class NewOrderBatchHandler(BatchHandler):  # pylint: disable=too-many-public-met
         ]
 
         # make order
-        kw = dict([(field, getattr(batch, field)) for field in batch_fields])
+        kw = {field: getattr(batch, field) for field in batch_fields}
         kw["order_id"] = batch.id
         kw["created_by"] = user
         order = model.Order(**kw)
@@ -1265,7 +1265,7 @@ class NewOrderBatchHandler(BatchHandler):  # pylint: disable=too-many-public-met
         def convert(row, i):  # pylint: disable=unused-argument
 
             # make order item
-            kw = dict([(field, getattr(row, field)) for field in row_fields])
+            kw = {field: getattr(row, field) for field in row_fields}
             item = model.OrderItem(**kw)
             order.items.append(item)
 
diff --git a/src/sideshow/web/views/orders.py b/src/sideshow/web/views/orders.py
index c01bffb..500fe4c 100644
--- a/src/sideshow/web/views/orders.py
+++ b/src/sideshow/web/views/orders.py
@@ -308,12 +308,10 @@ class OrderView(MasterView):  # pylint: disable=too-many-public-methods
             context["default_item_discount"] = self.app.render_quantity(
                 self.batch_handler.get_default_item_discount()
             )
-            context["dept_item_discounts"] = dict(
-                [
-                    (d["department_id"], d["default_item_discount"])
-                    for d in self.get_dept_item_discounts()
-                ]
-            )
+            context["dept_item_discounts"] = {
+                d["department_id"]: d["default_item_discount"]
+                for d in self.get_dept_item_discounts()
+            }
 
         return self.render_to_response("create", context)