From c01f9395f0708da4ba720f4122110effdf6f9e46 Mon Sep 17 00:00:00 2001
From: Lance Edgar <lance@wuttaproject.org>
Date: Mon, 1 Sep 2025 14:56:35 -0500
Subject: [PATCH] fix: fix 'inconsistent-return-statements' for pylint

---
 .pylintrc                          | 1 -
 src/sideshow/batch/neworder.py     | 3 +++
 src/sideshow/orders.py             | 1 +
 src/sideshow/web/views/orders.py   | 2 ++
 src/sideshow/web/views/products.py | 1 +
 src/sideshow/web/views/stores.py   | 1 +
 6 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/.pylintrc b/.pylintrc
index ecb5a50..e6d4cca 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -13,4 +13,3 @@ disable=fixme,
         consider-using-set-comprehension,
         empty-docstring,
         implicit-str-concat,
-        inconsistent-return-statements,
diff --git a/src/sideshow/batch/neworder.py b/src/sideshow/batch/neworder.py
index f445f4f..09c07cf 100644
--- a/src/sideshow/batch/neworder.py
+++ b/src/sideshow/batch/neworder.py
@@ -117,6 +117,7 @@ class NewOrderBatchHandler(BatchHandler):  # pylint: disable=too-many-public-met
         discount = self.config.get("sideshow.orders.default_item_discount")
         if discount:
             return decimal.Decimal(discount)
+        return None
 
     def autocomplete_customers_external(self, session, term, user=None):
         """
@@ -1074,6 +1075,8 @@ class NewOrderBatchHandler(BatchHandler):  # pylint: disable=too-many-public-met
         if not rows:
             return "Must add at least one valid item"
 
+        return None
+
     def get_effective_rows(self, batch):
         """
         Only rows with
diff --git a/src/sideshow/orders.py b/src/sideshow/orders.py
index 7d5cb53..0222f30 100644
--- a/src/sideshow/orders.py
+++ b/src/sideshow/orders.py
@@ -105,6 +105,7 @@ class OrderHandler(GenericHandler):
             enum.ORDER_ITEM_STATUS_INACTIVE,
         ):
             return "warning"
+        return None
 
     def resolve_pending_product(self, pending_product, product_info, user, note=None):
         """
diff --git a/src/sideshow/web/views/orders.py b/src/sideshow/web/views/orders.py
index 22101a7..44dddf3 100644
--- a/src/sideshow/web/views/orders.py
+++ b/src/sideshow/web/views/orders.py
@@ -1057,6 +1057,7 @@ class OrderView(MasterView):  # pylint: disable=too-many-public-methods
         variant = self.order_handler.item_status_to_variant(item.status_code)
         if variant:
             return f"has-background-{variant}"
+        return None
 
     def render_status_code(self, item, key, value):  # pylint: disable=unused-argument
         """ """
@@ -1407,6 +1408,7 @@ class OrderItemView(MasterView):
         variant = self.order_handler.item_status_to_variant(item.status_code)
         if variant:
             return f"has-background-{variant}"
+        return None
 
     def configure_form(self, f):
         """ """
diff --git a/src/sideshow/web/views/products.py b/src/sideshow/web/views/products.py
index 2086403..4dd58b1 100644
--- a/src/sideshow/web/views/products.py
+++ b/src/sideshow/web/views/products.py
@@ -319,6 +319,7 @@ class PendingProductView(MasterView):
         enum = self.app.enum
         if product.status == enum.PendingProductStatus.IGNORED:
             return "has-background-warning"
+        return None
 
     def configure_form(self, f):
         """ """
diff --git a/src/sideshow/web/views/stores.py b/src/sideshow/web/views/stores.py
index 9784ab4..247d1c8 100644
--- a/src/sideshow/web/views/stores.py
+++ b/src/sideshow/web/views/stores.py
@@ -68,6 +68,7 @@ class StoreView(MasterView):
         """ """
         if store.archived:
             return "has-background-warning"
+        return None
 
     def configure_form(self, f):
         """ """