From 5a0d59ee3658853262d51a44aa3c76c40d960156 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Mon, 1 Sep 2025 14:35:58 -0500 Subject: [PATCH] fix: fix 'redefined-outer-name' for pylint --- .pylintrc | 1 - src/sideshow/cli/install.py | 6 +++--- src/sideshow/web/views/batch/neworder.py | 4 +++- src/sideshow/web/views/customers.py | 8 ++++++-- src/sideshow/web/views/orders.py | 24 ++++++++++++++++++------ src/sideshow/web/views/products.py | 8 ++++++-- src/sideshow/web/views/stores.py | 4 +++- 7 files changed, 39 insertions(+), 16 deletions(-) diff --git a/.pylintrc b/.pylintrc index e0085ba..aaecedd 100644 --- a/.pylintrc +++ b/.pylintrc @@ -20,4 +20,3 @@ disable=fixme, no-else-return, no-member, no-self-argument, - redefined-outer-name, diff --git a/src/sideshow/cli/install.py b/src/sideshow/cli/install.py index 06231f6..38ebc25 100644 --- a/src/sideshow/cli/install.py +++ b/src/sideshow/cli/install.py @@ -2,7 +2,7 @@ ################################################################################ # # Sideshow -- Case/Special Order Tracker -# Copyright © 2024 Lance Edgar +# Copyright © 2024-2025 Lance Edgar # # This file is part of Sideshow. # @@ -38,10 +38,10 @@ def install( """ config = ctx.parent.wutta_config app = config.get_app() - install = app.get_install_handler( + handler = app.get_install_handler( pkg_name="sideshow", app_title="Sideshow", pypi_name="Sideshow", egg_name="Sideshow", ) - install.run() + handler.run() diff --git a/src/sideshow/web/views/batch/neworder.py b/src/sideshow/web/views/batch/neworder.py index 99ffda5..05fe99f 100644 --- a/src/sideshow/web/views/batch/neworder.py +++ b/src/sideshow/web/views/batch/neworder.py @@ -217,7 +217,9 @@ class NewOrderBatchView(BatchMasterView): def defaults(config, **kwargs): base = globals() - NewOrderBatchView = kwargs.get("NewOrderBatchView", base["NewOrderBatchView"]) + NewOrderBatchView = kwargs.get( # pylint: disable=redefined-outer-name + "NewOrderBatchView", base["NewOrderBatchView"] + ) NewOrderBatchView.defaults(config) diff --git a/src/sideshow/web/views/customers.py b/src/sideshow/web/views/customers.py index 4076ab5..0631be4 100644 --- a/src/sideshow/web/views/customers.py +++ b/src/sideshow/web/views/customers.py @@ -415,10 +415,14 @@ class PendingCustomerView(MasterView): def defaults(config, **kwargs): base = globals() - LocalCustomerView = kwargs.get("LocalCustomerView", base["LocalCustomerView"]) + LocalCustomerView = kwargs.get( # pylint: disable=redefined-outer-name + "LocalCustomerView", base["LocalCustomerView"] + ) LocalCustomerView.defaults(config) - PendingCustomerView = kwargs.get("PendingCustomerView", base["PendingCustomerView"]) + PendingCustomerView = kwargs.get( # pylint: disable=redefined-outer-name + "PendingCustomerView", base["PendingCustomerView"] + ) PendingCustomerView.defaults(config) diff --git a/src/sideshow/web/views/orders.py b/src/sideshow/web/views/orders.py index c1676db..1df30a1 100644 --- a/src/sideshow/web/views/orders.py +++ b/src/sideshow/web/views/orders.py @@ -2372,22 +2372,34 @@ class DeliveryView(OrderItemView): def defaults(config, **kwargs): base = globals() - OrderView = kwargs.get("OrderView", base["OrderView"]) + OrderView = kwargs.get( # pylint: disable=redefined-outer-name + "OrderView", base["OrderView"] + ) OrderView.defaults(config) - OrderItemView = kwargs.get("OrderItemView", base["OrderItemView"]) + OrderItemView = kwargs.get( # pylint: disable=redefined-outer-name + "OrderItemView", base["OrderItemView"] + ) OrderItemView.defaults(config) - PlacementView = kwargs.get("PlacementView", base["PlacementView"]) + PlacementView = kwargs.get( # pylint: disable=redefined-outer-name + "PlacementView", base["PlacementView"] + ) PlacementView.defaults(config) - ReceivingView = kwargs.get("ReceivingView", base["ReceivingView"]) + ReceivingView = kwargs.get( # pylint: disable=redefined-outer-name + "ReceivingView", base["ReceivingView"] + ) ReceivingView.defaults(config) - ContactView = kwargs.get("ContactView", base["ContactView"]) + ContactView = kwargs.get( # pylint: disable=redefined-outer-name + "ContactView", base["ContactView"] + ) ContactView.defaults(config) - DeliveryView = kwargs.get("DeliveryView", base["DeliveryView"]) + DeliveryView = kwargs.get( # pylint: disable=redefined-outer-name + "DeliveryView", base["DeliveryView"] + ) DeliveryView.defaults(config) diff --git a/src/sideshow/web/views/products.py b/src/sideshow/web/views/products.py index 9127d89..2da8225 100644 --- a/src/sideshow/web/views/products.py +++ b/src/sideshow/web/views/products.py @@ -581,10 +581,14 @@ class PendingProductView(MasterView): def defaults(config, **kwargs): base = globals() - LocalProductView = kwargs.get("LocalProductView", base["LocalProductView"]) + LocalProductView = kwargs.get( # pylint: disable=redefined-outer-name + "LocalProductView", base["LocalProductView"] + ) LocalProductView.defaults(config) - PendingProductView = kwargs.get("PendingProductView", base["PendingProductView"]) + PendingProductView = kwargs.get( # pylint: disable=redefined-outer-name + "PendingProductView", base["PendingProductView"] + ) PendingProductView.defaults(config) diff --git a/src/sideshow/web/views/stores.py b/src/sideshow/web/views/stores.py index 4c3c1df..1b07ff7 100644 --- a/src/sideshow/web/views/stores.py +++ b/src/sideshow/web/views/stores.py @@ -111,7 +111,9 @@ class StoreView(MasterView): def defaults(config, **kwargs): base = globals() - StoreView = kwargs.get("StoreView", base["StoreView"]) + StoreView = kwargs.get( # pylint: disable=redefined-outer-name + "StoreView", base["StoreView"] + ) StoreView.defaults(config)