From 281d654e321c4aff5548afa8e7eac70b6d5f5134 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Mon, 1 Sep 2025 14:54:59 -0500 Subject: [PATCH] fix: fix 'invalid-name' for pylint --- .pylintrc | 1 - src/sideshow/orders.py | 6 +++--- src/sideshow/web/views/batch/neworder.py | 2 +- src/sideshow/web/views/customers.py | 6 +++--- src/sideshow/web/views/orders.py | 12 ++++++------ src/sideshow/web/views/products.py | 6 +++--- src/sideshow/web/views/stores.py | 2 +- 7 files changed, 17 insertions(+), 18 deletions(-) diff --git a/.pylintrc b/.pylintrc index a9e1cd7..ecb5a50 100644 --- a/.pylintrc +++ b/.pylintrc @@ -14,4 +14,3 @@ disable=fixme, empty-docstring, implicit-str-concat, inconsistent-return-statements, - invalid-name, diff --git a/src/sideshow/orders.py b/src/sideshow/orders.py index 7ff701a..7d5cb53 100644 --- a/src/sideshow/orders.py +++ b/src/sideshow/orders.py @@ -72,15 +72,15 @@ class OrderHandler(GenericHandler): else: case_qty = self.app.render_quantity(case_size) unit_qty = self.app.render_quantity(order_qty * case_size) - CS = enum.ORDER_UOM[enum.ORDER_UOM_CASE] - EA = enum.ORDER_UOM[enum.ORDER_UOM_UNIT] + CS = enum.ORDER_UOM[enum.ORDER_UOM_CASE] # pylint: disable=invalid-name + EA = enum.ORDER_UOM[enum.ORDER_UOM_UNIT] # pylint: disable=invalid-name order_qty = self.app.render_quantity(order_qty) times = "×" if html else "x" return f"{order_qty} {CS} ({times} {case_qty} = {unit_qty} {EA})" # units unit_qty = self.app.render_quantity(order_qty) - EA = enum.ORDER_UOM[enum.ORDER_UOM_UNIT] + EA = enum.ORDER_UOM[enum.ORDER_UOM_UNIT] # pylint: disable=invalid-name return f"{unit_qty} {EA}" def item_status_to_variant(self, status_code): diff --git a/src/sideshow/web/views/batch/neworder.py b/src/sideshow/web/views/batch/neworder.py index 115239d..202478c 100644 --- a/src/sideshow/web/views/batch/neworder.py +++ b/src/sideshow/web/views/batch/neworder.py @@ -217,7 +217,7 @@ class NewOrderBatchView(BatchMasterView): def defaults(config, **kwargs): # pylint: disable=missing-function-docstring base = globals() - NewOrderBatchView = kwargs.get( # pylint: disable=redefined-outer-name + NewOrderBatchView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "NewOrderBatchView", base["NewOrderBatchView"] ) NewOrderBatchView.defaults(config) diff --git a/src/sideshow/web/views/customers.py b/src/sideshow/web/views/customers.py index 52bc36b..c989af5 100644 --- a/src/sideshow/web/views/customers.py +++ b/src/sideshow/web/views/customers.py @@ -415,13 +415,13 @@ class PendingCustomerView(MasterView): def defaults(config, **kwargs): # pylint: disable=missing-function-docstring base = globals() - LocalCustomerView = kwargs.get( # pylint: disable=redefined-outer-name + LocalCustomerView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "LocalCustomerView", base["LocalCustomerView"] ) LocalCustomerView.defaults(config) - PendingCustomerView = kwargs.get( # pylint: disable=redefined-outer-name - "PendingCustomerView", base["PendingCustomerView"] + PendingCustomerView = ( # pylint: disable=redefined-outer-name,invalid-name + kwargs.get("PendingCustomerView", base["PendingCustomerView"]) ) PendingCustomerView.defaults(config) diff --git a/src/sideshow/web/views/orders.py b/src/sideshow/web/views/orders.py index b1914ac..22101a7 100644 --- a/src/sideshow/web/views/orders.py +++ b/src/sideshow/web/views/orders.py @@ -2374,32 +2374,32 @@ class DeliveryView(OrderItemView): def defaults(config, **kwargs): # pylint: disable=missing-function-docstring base = globals() - OrderView = kwargs.get( # pylint: disable=redefined-outer-name + OrderView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "OrderView", base["OrderView"] ) OrderView.defaults(config) - OrderItemView = kwargs.get( # pylint: disable=redefined-outer-name + OrderItemView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "OrderItemView", base["OrderItemView"] ) OrderItemView.defaults(config) - PlacementView = kwargs.get( # pylint: disable=redefined-outer-name + PlacementView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "PlacementView", base["PlacementView"] ) PlacementView.defaults(config) - ReceivingView = kwargs.get( # pylint: disable=redefined-outer-name + ReceivingView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "ReceivingView", base["ReceivingView"] ) ReceivingView.defaults(config) - ContactView = kwargs.get( # pylint: disable=redefined-outer-name + ContactView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "ContactView", base["ContactView"] ) ContactView.defaults(config) - DeliveryView = kwargs.get( # pylint: disable=redefined-outer-name + DeliveryView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "DeliveryView", base["DeliveryView"] ) DeliveryView.defaults(config) diff --git a/src/sideshow/web/views/products.py b/src/sideshow/web/views/products.py index 6ead48a..2086403 100644 --- a/src/sideshow/web/views/products.py +++ b/src/sideshow/web/views/products.py @@ -581,13 +581,13 @@ class PendingProductView(MasterView): def defaults(config, **kwargs): # pylint: disable=missing-function-docstring base = globals() - LocalProductView = kwargs.get( # pylint: disable=redefined-outer-name + LocalProductView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "LocalProductView", base["LocalProductView"] ) LocalProductView.defaults(config) - PendingProductView = kwargs.get( # pylint: disable=redefined-outer-name - "PendingProductView", base["PendingProductView"] + PendingProductView = ( # pylint: disable=redefined-outer-name,invalid-name + kwargs.get("PendingProductView", base["PendingProductView"]) ) PendingProductView.defaults(config) diff --git a/src/sideshow/web/views/stores.py b/src/sideshow/web/views/stores.py index 06c749f..9784ab4 100644 --- a/src/sideshow/web/views/stores.py +++ b/src/sideshow/web/views/stores.py @@ -111,7 +111,7 @@ class StoreView(MasterView): def defaults(config, **kwargs): # pylint: disable=missing-function-docstring base = globals() - StoreView = kwargs.get( # pylint: disable=redefined-outer-name + StoreView = kwargs.get( # pylint: disable=redefined-outer-name,invalid-name "StoreView", base["StoreView"] ) StoreView.defaults(config)