diff --git a/.pylintrc b/.pylintrc index 527cc44..7eb5e2c 100644 --- a/.pylintrc +++ b/.pylintrc @@ -1,5 +1,4 @@ # -*- mode: conf; -*- [MESSAGES CONTROL] -disable=fixme, - duplicate-code, +disable=fixme diff --git a/src/sideshow/db/model/orders.py b/src/sideshow/db/model/orders.py index d1ff229..ff99001 100644 --- a/src/sideshow/db/model/orders.py +++ b/src/sideshow/db/model/orders.py @@ -328,7 +328,9 @@ class OrderItemMixin: # pylint: disable=too-few-public-methods ) -class Order(OrderMixin, model.Base): # pylint: disable=too-few-public-methods +class Order( # pylint: disable=too-few-public-methods,duplicate-code + OrderMixin, model.Base +): """ Represents an :term:`order` for a customer. Each order has one or more :attr:`items`. diff --git a/src/sideshow/db/model/products.py b/src/sideshow/db/model/products.py index 0b11308..f549b1c 100644 --- a/src/sideshow/db/model/products.py +++ b/src/sideshow/db/model/products.py @@ -34,7 +34,7 @@ from wuttjamaican.db import model from sideshow.enum import PendingProductStatus -class ProductMixin: +class ProductMixin: # pylint: disable=duplicate-code """ Base class for product tables. This has shared columns, used by e.g.: diff --git a/src/sideshow/web/views/batch/neworder.py b/src/sideshow/web/views/batch/neworder.py index 6b0ba60..15973d9 100644 --- a/src/sideshow/web/views/batch/neworder.py +++ b/src/sideshow/web/views/batch/neworder.py @@ -84,6 +84,7 @@ class NewOrderBatchView(BatchMasterView): # pylint: disable=abstract-method "executed": {"active": True, "verb": "is_null"}, } + # pylint: disable=duplicate-code form_fields = [ "id", "store_id", @@ -101,6 +102,7 @@ class NewOrderBatchView(BatchMasterView): # pylint: disable=abstract-method "executed", "executed_by", ] + # pylint: enable=duplicate-code row_labels = { "product_scancode": "Scancode", diff --git a/src/sideshow/web/views/customers.py b/src/sideshow/web/views/customers.py index 3f34a4b..6db0f02 100644 --- a/src/sideshow/web/views/customers.py +++ b/src/sideshow/web/views/customers.py @@ -56,6 +56,7 @@ class LocalCustomerView(MasterView): # pylint: disable=abstract-method "external_id": "External ID", } + # pylint: disable=duplicate-code grid_columns = [ "external_id", "full_name", @@ -64,9 +65,11 @@ class LocalCustomerView(MasterView): # pylint: disable=abstract-method "phone_number", "email_address", ] + # pylint: enable=duplicate-code sort_defaults = "full_name" + # pylint: disable=duplicate-code form_fields = [ "external_id", "full_name", @@ -77,6 +80,7 @@ class LocalCustomerView(MasterView): # pylint: disable=abstract-method "orders", "new_order_batches", ] + # pylint: enable=duplicate-code def configure_grid(self, grid): # pylint: disable=empty-docstring """ """ @@ -171,6 +175,7 @@ class PendingCustomerView(PendingMixin, MasterView): # pylint: disable=abstract "customer_id": "Customer ID", } + # pylint: disable=duplicate-code grid_columns = [ "full_name", "first_name", @@ -182,9 +187,11 @@ class PendingCustomerView(PendingMixin, MasterView): # pylint: disable=abstract "created", "created_by", ] + # pylint: enable=duplicate-code sort_defaults = "full_name" + # pylint: disable=duplicate-code form_fields = [ "customer_id", "full_name", @@ -198,6 +205,7 @@ class PendingCustomerView(PendingMixin, MasterView): # pylint: disable=abstract "orders", "new_order_batches", ] + # pylint: enable=duplicate-code def configure_grid(self, grid): # pylint: disable=empty-docstring """ """ diff --git a/src/sideshow/web/views/orders.py b/src/sideshow/web/views/orders.py index 14e16dd..d38b728 100644 --- a/src/sideshow/web/views/orders.py +++ b/src/sideshow/web/views/orders.py @@ -101,6 +101,7 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods sort_defaults = ("order_id", "desc") + # pylint: disable=duplicate-code form_fields = [ "order_id", "store_id", @@ -114,6 +115,7 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods "created", "created_by", ] + # pylint: enable=duplicate-code has_rows = True row_model_class = OrderItem @@ -121,6 +123,7 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods rows_sort_defaults = "sequence" rows_viewable = True + # pylint: disable=duplicate-code row_labels = { "product_scancode": "Scancode", "product_brand": "Brand", @@ -130,7 +133,9 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods "order_uom": "Order UOM", "status_code": "Status", } + # pylint: enable=duplicate-code + # pylint: disable=duplicate-code row_grid_columns = [ "sequence", "product_scancode", @@ -145,7 +150,9 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods "total_price", "status_code", ] + # pylint: enable=duplicate-code + # pylint: disable=duplicate-code PENDING_PRODUCT_ENTRY_FIELDS = [ "scancode", "brand_name", @@ -159,6 +166,7 @@ class OrderView(MasterView): # pylint: disable=too-many-public-methods "unit_cost", "unit_price_reg", ] + # pylint: enable=duplicate-code def __init__(self, request, context=None): super().__init__(request, context=context) @@ -1311,6 +1319,7 @@ class OrderItemView(MasterView): # pylint: disable=abstract-method sort_defaults = ("order_id", "desc") + # pylint: disable=duplicate-code form_fields = [ "order", # 'customer_name', @@ -1341,6 +1350,7 @@ class OrderItemView(MasterView): # pylint: disable=abstract-method "paid_amount", "payment_transaction_number", ] + # pylint: enable=duplicate-code def __init__(self, request, context=None): super().__init__(request, context=context) diff --git a/src/sideshow/web/views/products.py b/src/sideshow/web/views/products.py index 6f7fe54..e1eec5b 100644 --- a/src/sideshow/web/views/products.py +++ b/src/sideshow/web/views/products.py @@ -71,6 +71,7 @@ class LocalProductView(MasterView): # pylint: disable=abstract-method sort_defaults = "scancode" + # pylint: disable=duplicate-code form_fields = [ "external_id", "scancode", @@ -89,6 +90,7 @@ class LocalProductView(MasterView): # pylint: disable=abstract-method "orders", "new_order_batches", ] + # pylint: enable=duplicate-code def configure_grid(self, grid): # pylint: disable=empty-docstring """ """