From fdcf23f65f91c22936ba0984a7d27a16ed1980e2 Mon Sep 17 00:00:00 2001 From: Lance Edgar Date: Fri, 4 Sep 2020 20:30:33 -0500 Subject: [PATCH] Stop including 'complete' filter by default for purchasing batches --- tailbone/views/purchasing/batch.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tailbone/views/purchasing/batch.py b/tailbone/views/purchasing/batch.py index 4f7a14e6..e8bc5ba7 100644 --- a/tailbone/views/purchasing/batch.py +++ b/tailbone/views/purchasing/batch.py @@ -203,9 +203,12 @@ class PurchasingBatchView(BatchMasterView): default_active=True, default_verb='contains') g.sorters['buyer'] = g.make_sorter(model.Person.display_name) - if self.request.has_perm('{}.execute'.format(self.get_permission_prefix())): - g.filters['complete'].default_active = True - g.filters['complete'].default_verb = 'is_true' + # TODO: we used to include the 'complete' filter by default, but it + # seems to likely be confusing for newcomers, so it is no longer + # default. not sure if there are any other implications...? + # if self.request.has_perm('{}.execute'.format(self.get_permission_prefix())): + # g.filters['complete'].default_active = True + # g.filters['complete'].default_verb = 'is_true' # invoice_total g.set_type('invoice_total', 'currency')