From 3cf4c0f8e40d89cae2ec2a998cf029630006bd63 Mon Sep 17 00:00:00 2001
From: Lance Edgar <lance@edbob.org>
Date: Mon, 23 Aug 2021 19:26:50 -0500
Subject: [PATCH] Require explicit opt-in for "clicking grid row checks box"
 feature

sometimes it makes sense *not* to enable that, in which case disabled
probably should be the default
---
 tailbone/grids/core.py              | 2 ++
 tailbone/templates/grids/buefy.mako | 2 ++
 tailbone/views/master.py            | 5 +++++
 3 files changed, 9 insertions(+)

diff --git a/tailbone/grids/core.py b/tailbone/grids/core.py
index 5c8e1c87..f6df3375 100644
--- a/tailbone/grids/core.py
+++ b/tailbone/grids/core.py
@@ -75,6 +75,7 @@ class Grid(object):
                  sortable=False, sorters={}, default_sortkey=None, default_sortdir='asc',
                  pageable=False, default_pagesize=20, default_page=1,
                  checkboxes=False, checked=None, check_handler=None, check_all_handler=None,
+                 clicking_row_checks_box=False,
                  main_actions=[], more_actions=[], delete_speedbump=False,
                  ajax_data_url=None, component='tailbone-grid',
                  **kwargs):
@@ -128,6 +129,7 @@ class Grid(object):
             self.checked = lambda item: False
         self.check_handler = check_handler
         self.check_all_handler = check_all_handler
+        self.clicking_row_checks_box = clicking_row_checks_box
 
         self.main_actions = main_actions or []
         self.more_actions = more_actions or []
diff --git a/tailbone/templates/grids/buefy.mako b/tailbone/templates/grids/buefy.mako
index 00b9ce9e..6eaff11a 100644
--- a/tailbone/templates/grids/buefy.mako
+++ b/tailbone/templates/grids/buefy.mako
@@ -143,8 +143,10 @@
        :checkable="checkable"
        % if grid.checkboxes:
        :checked-rows.sync="checkedRows"
+       % if grid.clicking_row_checks_box:
        @click="rowClick"
        % endif
+       % endif
        % if grid.check_handler:
        @check="${grid.check_handler}"
        % endif
diff --git a/tailbone/views/master.py b/tailbone/views/master.py
index 6d5a3d96..a1d6da79 100644
--- a/tailbone/views/master.py
+++ b/tailbone/views/master.py
@@ -73,6 +73,10 @@ class MasterView(View):
     pageable = True
     checkboxes = False
 
+    # set to True to allow user to click "anywhere" in a row in order
+    # to toggle its checkbox
+    clicking_row_checks_box = False
+
     # set to True in order to encode search values as utf-8
     use_byte_string_filters = False
 
@@ -399,6 +403,7 @@ class MasterView(View):
             'url': lambda obj: self.get_action_url('view', obj),
             'checkboxes': checkboxes,
             'checked': self.checked,
+            'clicking_row_checks_box': self.clicking_row_checks_box,
             'assume_local_times': self.has_local_times,
         }
         if 'main_actions' not in kwargs and 'more_actions' not in kwargs: