From a0837a758f20c061e9769ac3b7287b414329478e Mon Sep 17 00:00:00 2001
From: Gaetan Delannay <gaetan.delannay@gmail.com>
Date: Wed, 11 Jul 2012 17:27:40 +0200
Subject: [PATCH] [gen] Bugfix in the 'change user id' function. Now, the
 method browses every object in the database and updates local roles where the
 old ID was potentially mentioned.

---
 gen/mixins/__init__.py      | 13 +++++++++++++
 gen/wrappers/UserWrapper.py | 36 ++++++++++++++++++++++++++++--------
 2 files changed, 41 insertions(+), 8 deletions(-)

diff --git a/gen/mixins/__init__.py b/gen/mixins/__init__.py
index feb4fa8..c6c4b37 100644
--- a/gen/mixins/__init__.py
+++ b/gen/mixins/__init__.py
@@ -939,6 +939,19 @@ class BaseMixin:
             self.reindex()
         return updated
 
+    def applyUserIdChange(self, oldId, newId):
+        '''A user whose ID was p_oldId has now p_newId. If the old ID was
+           mentioned in self's local roles, update it to the new ID. This
+           method returns 1 if a change occurred, 0 else.'''
+        if oldId in self.__ac_local_roles__:
+            localRoles = self.__ac_local_roles__.copy()
+            localRoles[newId] = localRoles[oldId]
+            del localRoles[oldId]
+            self.__ac_local_roles__ = localRoles
+            self.reindex()
+            return 1
+        return 0
+
     def hasHistory(self):
         '''Has this object an history?'''
         if hasattr(self.aq_base, 'workflow_history') and self.workflow_history:
diff --git a/gen/wrappers/UserWrapper.py b/gen/wrappers/UserWrapper.py
index fc6c4f5..0239dc2 100644
--- a/gen/wrappers/UserWrapper.py
+++ b/gen/wrappers/UserWrapper.py
@@ -78,6 +78,33 @@ class UserWrapper(AbstractWrapper):
                  (msgPart, self.user.getId(), login))
         return newPassword
 
+    def setLogin(self, oldLogin, newLogin):
+        '''Changes the login of this user from p_oldLogin to p_newLogin.'''
+        self.login = newLogin
+        # Update the corresponding Zope-level user
+        aclUsers = self.o.acl_users
+        zopeUser = aclUsers.getUserById(oldLogin)
+        zopeUser.name = newLogin
+        del aclUsers.data[oldLogin]
+        aclUsers.data[newLogin] = zopeUser
+        # Update the email if the email corresponds to the login.
+        email = self.email
+        if email == oldLogin:
+            self.email = newLogin
+        # Update the title, which is the login
+        self.title = newLogin
+        # Browse all objects of the database and update potential local roles
+        # that referred to the old login.
+        context = {'nb': 0, 'old': oldLogin, 'new': newLogin}
+        for className in self.o.getProductConfig().allClassNames:
+            self.compute(className, context=context, noSecurity=True,
+                         expression="ctx['nb'] += obj.o.applyUserIdChange(" \
+                                    "ctx['old'], ctx['new'])")
+        self.log("Login '%s' renamed to '%s' by '%s'." % \
+                 (oldLogin, newLogin, self.user.getId()))
+        self.log('Login change: local roles updated in %d object(s).' % \
+                 context['nb'])
+
     def getGrantableRoles(self):
         '''Returns the list of roles that the admin can grant to a user.'''
         res = []
@@ -116,14 +143,7 @@ class UserWrapper(AbstractWrapper):
             # Update the login itself if the user has changed it.
             oldLogin = self.o._oldLogin
             if oldLogin and (oldLogin != login):
-                zopeUser = aclUsers.getUserById(oldLogin)
-                zopeUser.name = login
-                del aclUsers.data[oldLogin]
-                aclUsers.data[login] = zopeUser
-                # Update the email if the email corresponds to the login.
-                email = self.email
-                if email == oldLogin:
-                    self.email = login
+                self.setLogin(oldLogin, login)
             del self.o._oldLogin
             # Update roles at the Zope level.
             zopeUser = aclUsers.getUserById(login)